Remove the property intercepters for AssemblyVersion and FileVersion

dotnet / project-system

The .NET Project System for Visual Studio

MIT License

972 stars 389 forks source link

Remove the property intercepters for AssemblyVersion and FileVersion #1017

Open mavasani opened 7 years ago

mavasani commented 7 years ago

Defaults for these are provided by the SDK target "GetAssemblyInfo", we should try to use this target to compute the defaults instead of the duplicate logic defined in AssemblyVersionValueProvider and FileVersionValueProvider.

mavasani commented 7 years ago

This is now blocked by https://github.com/dotnet/sdk/issues/574

dmonroym commented 4 years ago

@davkean dotnet/sdk#574 got closed so we were thinking of closing this as well, can you double check?