dotnet / project-system

The .NET Project System for Visual Studio
MIT License
967 stars 386 forks source link

"Edit .... .csproj" is not available if project fails to load. #1177

Open NickCraver opened 7 years ago

NickCraver commented 7 years ago

If you hit an error like https://github.com/dotnet/roslyn-project-system/issues/1176, the project fails to load, but this also makes it harder to fix, because the option to edit the .csproj file is no longer available in intellisense. Here's the repo in the failed state: https://github.com/MiniProfiler/dotnet/tree/6e2ccc233da4f9d8614a57573857c885292e1881

and here's a screenshot:

screen shot 2017-01-16 at 13 53 57 screen shot 2017-01-16 at 13 54 01
davkean commented 7 years ago

I suspect a few things:

srivatsn commented 7 years ago

@333fred can you try to chase this down?

333fred commented 7 years ago

Figured out the cause of this. CPS displays a different context menu in this case. Adding the command to that node causes everything to work correctly.

333fred commented 7 years ago

I've opened https://github.com/dotnet/roslyn-project-system/pull/1341. There needs to be some discussion on the appropriate way to fix this, which will happen on that PR.

drewnoakes commented 5 years ago

This has been fixed in d16.0stg:

image

davkean commented 5 years ago

@drewnoakes That's the stub hierarchy handling that and kicks in when the project factory fails, above is the case where CPS project factory creation succeeds, but CPS latter hits an error.