search

dotnet / project-system

The .NET Project System for Visual Studio
MIT License
967 stars 386 forks source link

Legacy designers expect DTAR to not find assemblies not referenced by the project #4094

Open Tanya-Solyanik opened 5 years ago

Tanya-Solyanik commented 5 years ago

Promoting the following comment in DesignTimeAssemblyResolution code to a work item:

    internal partial class DesignTimeAssemblyResolution : IVsDesignTimeAssemblyResolution, IDisposable
    {
<snip>
        // This implementation will work for .NET Core based projects, but we might run into unexpected behavior when bringing up legacy projects where designers/components
        // expect to ask for/use types that are not currently referenced by the project. We should revisit at that time.

Winforms implementation of TypeResolutionService expects that DTAR resolves only assemblies that are referenced by the project in the drag-and-drop from the toolbox scenario.

Pilchie commented 5 years ago

@davkean - can you help us understand this concern?

davkean commented 5 years ago

@nguerrera is coming up/working on a design for this and we can change our code to react to that. This is dependent on whether WinForms/WPF are considered part of the "framework" (show up in FrameworkList.xml passed to RAR) when those components are installed.