dotnet / project-system

The .NET Project System for Visual Studio
MIT License
969 stars 387 forks source link

Fields and labels not correctly sized on Project Properties Debug tab #427

Closed srivatsn closed 7 years ago

srivatsn commented 8 years ago

This is a regression for desktop projects:

  1. Create a desktop console application and open the Debug property page:

image

davkean commented 8 years ago

What is that page...

davkean commented 8 years ago

Looks a whole lot of broken

davkean commented 8 years ago

This is probably multiple monitors with different DPIs, will investigate this week.

davkean commented 8 years ago

I've been unable to repro this - if you can repro this, can you list:

Resolutions of all screens DPI of all screens

davkean commented 7 years ago

@srivatsn Do you have a repro for this?

srivatsn commented 7 years ago

No, I can't seem to repro it anymore. Tried various configurations.

flcdrg commented 7 years ago

I see this on a Dell XPS 15 9550 laptop running 3840x2160 at 250%

image002

With 15.0.0-RC.4+26206.0 and WPF project open.

srivatsn commented 7 years ago

Pulling this into 15.1 - there's bunch of VS Feedback around this. In https://developercommunity.visualstudio.com/content/problem/22367/vs-2017-rc-project-properties-window-debug-tab-con.html there's a MSFT person as well who can repro it. Can you try contacting them?

adammodlin commented 7 years ago

@srivatsn Hi, that was me. I do indeed have multiple monitors (2 1920x1200, 1 1080x1920). DPI scaling is at 100% on all displays. I'm seeing this in C# library projects, not in desktop apps. Sc

davkean commented 7 years ago

@adammodlin Can you tell me exact monitors you are running?

adammodlin commented 7 years ago

@davkean Yes, here are the monitors (and the order they are daisy chained in case that matters):

Surface Pro 3 dock --> Dell U2415 --> Dell U2415 --> Dell P2414Hb.

They are all connected via DP or miniDP.

srivatsn commented 7 years ago

I've run into 5 more dupes on this on vsfeedback. We should prioritize this,

flcdrg commented 7 years ago

Seeing as I can repro this on my laptop, I thought I'd have a stab at pulling down the repo and firing it up. Any pointers on how the property pages work? Doesn't look like you're using the forms designer.

davkean commented 7 years ago

@flcdrg Thanks for the offer. The forms designer stopped opening when moved over to dogfood our repro in itself - we don't yet have WinForms support. I have an idea on what might be causing this - if I give you a branch to build can you test it?

flcdrg commented 7 years ago

Yes, happy to do that.

tomeo commented 7 years ago

image Same problem in latest VS update. 2560x1440

kroehne commented 7 years ago

Is there any workaround?

14.0.0-RTW+26228.4

image

davkean commented 7 years ago

@flcdrg I have a PR out, can you pull that branch and see if this resolves your issue?

flcdrg commented 7 years ago

Taking a look now..

davkean commented 7 years ago

@flcdrg Turns out I could repro your problem, and confirmed that it's fixed.

@adammodlin You are suffering from a slightly different issue - which I suspect is due to your natural DPI being less than 96, which I also expect to be fixed by the PR: https://github.com/dotnet/roslyn-project-system/pull/1803. It would be awesome if I could get you to verify this also.

flcdrg commented 7 years ago

Confirmed at my end that Debug tab looks correct now.

FYI I'm also seeing the 'opposite' problem for the Build tab. In that case the tab is stretching too far and ending up with a horizontal scrollbar. Do you want a new issue for that?

davkean commented 7 years ago

Thanks for the confirmation - I saw the same thing with the Build page and fixed that also: https://github.com/dotnet/roslyn-project-system/pull/1808.

adammodlin commented 7 years ago

@davkean Sure I can try to verify it tonight...what's the process behind getting that specific PR built?

davkean commented 7 years ago

@adammodlin:

  1. Git clone https://github.com/davkean/roslyn-project-system.git
  2. git checkout origin/DebugScaling
  3. Open VS Command Prompt
  4. Run Build.cmd
  5. devenv /RootSuffix RoslynDev

This will start a new instance of VS with the changes (won't affect your main instance).

davkean commented 7 years ago

Thanks all, we've confirmed that we've fixed this for all DPIs.

davkean commented 7 years ago

This fixed via https://github.com/dotnet/roslyn-project-system/pull/1803