Opt-in flag for VS Codespaces for c#

dotnet / project-system

The .NET Project System for Visual Studio

MIT License

972 stars 389 forks source link

Opt-in flag for VS Codespaces for c# #6217

Closed arunchndr closed 4 years ago

arunchndr commented 4 years ago

Visual Studio Version:

Summary: Potentially 3rd party project systems will get installed on the server in the future. This work is to require all project systems to opt-in to VS Codespaces. This is an opt-in model for the .NET Core project systems that we know support VS Codespaces.

Steps to Reproduce:

Not applicable

Expected Behavior:

Actual Behavior:

User Impact:

arunchndr commented 4 years ago

@davidwengier I have a commit for this that consumes the CPS packaging changes. Can I get permissions to the repo to create a PR?

drewnoakes commented 4 years ago

@arkalyanms you don't need permission to create a PR.

arunchndr commented 4 years ago

@drewnoakes c:\repos\project-system>git push --set-upstream origin dev/arkalyan/codespaces-optin remote: Permission to dotnet/project-system.git denied to arkalyanms. fatal: unable to access 'https://github.com/dotnet/project-system.git/': The requested URL returned error: 403

Perhaps the workflow is different from devops?

drewnoakes commented 4 years ago

Yes, the workflow is different here. You have to:

fork this repo
push to your fork
create a pull request from your fork to this repo

https://github.com/dotnet/project-system/blob/master/docs/repo/getting-started.md