Open tmeschter opened 3 years ago
It should probably accept CancellationToken
instead of the current timeout values. It's possible to model the latter with the former.
It should probably accept
CancellationToken
instead of the current timeout values. It's possible to model the latter with the former.
We should consider replacing the use of SequentialTaskExecutor
with a dataflow block. We are pulling items off a datasource and queuing them in the executor. It'd likely be simpler to just use dataflow throughout.
That said, it's unclear to me what would trigger a cancellation here. ILaunchSettingsProvider
seems like a place we could have accepted cancellation tokens, but it's a public API and hard to change now.
The
LaunchSettingsProvider
handles concurrent modifications by queuing them up in aSequentialTaskExecutor
where they are processed one at a time. Once aTask
is queued up there is no way of cancelling it, with the exception that disposing theLaunchSettingsProvider
will cancel all pendingTask
s.We should looking into updating
LaunchSettingsProvider
(andILaunchSettingsProvider
) to accept and respectCancellationToken
s.