search

dotnet / project-system

The .NET Project System for Visual Studio
MIT License
967 stars 386 forks source link

Program Icon property must copy .ico file to project (2) #7167

Closed sujitnayak closed 3 years ago

sujitnayak commented 3 years ago

Visual Studio Version: 16.10 P3 Main builds (31229.188.main on my machine)

Summary: Adding program icon with new Project Properties UX has a different behavior than the previous UX as described in Actual Behavior section.

Steps to Reproduce:

  1. Create WPF or Winforms project for .NET Core/.NET FX 5.0

  2. Go to Project Properties -> Application -> Resources tab and add program icon.

Expected Behavior: The .ico file gets copied to the project directory and ApplicationIcon property is written to project file with just the name of the .ico file

Actual Behavior: The icon file does not get copied to project folder and the ApplicationIcon property written to project file is fully qualified path to the .ico file.

User Impact: ClickOnce publish fails due to this breaking change as it expects the .ico file to be in the project directory.

melytc commented 3 years ago

For reference, this is the previous experience looks like: image

And this is the new experience: image

drewnoakes commented 3 years ago

See also #6457 for a very similar work item on a different property. I suspect the solution to each will look similar.