dotnet / project-system

The .NET Project System for Visual Studio
MIT License
959 stars 386 forks source link

Use strongly-typed error reporter #9412

Closed drewnoakes closed 3 months ago

drewnoakes commented 4 months ago

Historically, the IWorkspace type was in the host-agnostic layer, meaning that the error-reporing type was specific to the host. Since the introduction of C# DevKit, IWorkspace moved into the VS layer, and we no longer need this property to be of type object. Instead, it can be typed as IVsLanguageServiceBuildErrorReporter2, which simplifies consuming code.

NOTE there's a bunch more layer-change tidying that could be done here, but we'd want to validate it wouldn't impact C# DevKit first. cc @tmeschter to validate that this change is safe there.

Microsoft Reviewers: Open in CodeFlow