search

dotnet / project-system

The .NET Project System for Visual Studio
MIT License
959 stars 385 forks source link

Don't NGEN for all architectures #9453

Closed tmeschter closed 2 months ago

tmeschter commented 2 months ago

Fixes AB#1987317

We currently specify that Microsoft.VisualStudio.Editors.dll and Microsoft.VisualStudio.AppDesigner.dll should be NGEN'd for all architectures. This means that on an x64 system NGEN will run twice for each: once to create a 32-bit version, and once to create a 64-bit version. As we no longer ship a 32-bit version of VS the former is unnecessary, and we're just wasting time and resources on that NGEN and potentially delaying useful NGEN work.

This commit removes the <NGenArchitecture>all</NGenArchitecture> MSBuild property affecting these binaries. Without this property being set, NGEN will default to the current system architecture (e.g. AMD64 on an AMD64 system).

Microsoft Reviewers: Open in CodeFlow
drewnoakes commented 2 months ago

Merging this to increase the chance it get into its own insertion PR, so we can isolate any consequence of this change.