search

dotnet / project-system

The .NET Project System for Visual Studio
MIT License
968 stars 386 forks source link

make verified files as lf and utf8 #9498

Closed SimonCropp closed 2 months ago

SimonCropp commented 3 months ago

https://github.com/VerifyTests/Verify?tab=readme-ov-file#text-file-settings

Microsoft Reviewers: Open in CodeFlow
drewnoakes commented 2 months ago

Bumping to latest Verify requires bumping xunit too, which is blocked in #9457. Will revisit in future.

SimonCropp commented 2 months ago

@drewnoakes this PR doesnt bump verify. these settings work back several years with of Verify versions

drewnoakes commented 2 months ago

Understood. What I meant was that we had previously hit issues when trying to bump Verify (https://github.com/dotnet/project-system/pull/9056#issuecomment-1571178058).

We are currently seeing issues upgrading xunit (https://github.com/dotnet/project-system/pull/9457#issuecomment-2240820586). Once that is addressed, we can try updating Verify to the latest too.

Thanks again for the PR.