search

dotnet / razor

Compiler and tooling experience for Razor ASP.NET Core apps in Visual Studio, Visual Studio for Mac, and VS Code.
https://asp.net
MIT License
475 stars 184 forks source link

Fixing regression in legacy Razor editor used in .Net Framework projects #10542

Closed alexgav closed 3 days ago

alexgav commented 5 days ago

### Summary of the changes LspEditorFeatureDetector wasn't using project to detect whether LSP or Legacy editor needs to get used a result of !10490. This change restores usage of project capabilities to detect if project supports LSP editor, and fixes legacy editor usage in .Net Framework projects.

Fixes: C# spans in legacy Razor editor were completely broken. Initially found as Microsoft internal issue https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2094212.

phil-allen-msft commented 3 days ago

Do we want this in the release/dev17.11 branch?