Completion resolve endpoint skeleton

dotnet / razor

Compiler and tooling experience for Razor ASP.NET Core apps in Visual Studio, Visual Studio for Mac, and VS Code.

https://asp.net

MIT License

506 stars 196 forks source link

Completion resolve endpoint skeleton #11226

Closed alexgav closed 2 days ago

alexgav commented 4 days ago

### Summary of the changes

Adds skeleton for the cohosting completion resolve request handler
Adds TextDocument identifier data to the completion item so that resolve request handler is now callable by Roslyn (Roslyn uses that data to figure out that request should go to Razor)

Fixes: Partial fix for https://github.com/dotnet/razor/issues/11101

davidwengier commented 4 days ago

This feels like a commit that should be part of a larger PR, not a PR itself. I don't think we should be diverging the normal and cohosting endpoints like this, as that is how bugs creep in. Additionally, I can't see how there won't have to be changes to the completion resolve service in light of this change, and trying to review those changes separately in another PR will just be harder, with a complete lack of context.