search

dotnet / razor

Compiler and tooling experience for Razor ASP.NET Core apps in Visual Studio, Visual Studio for Mac, and VS Code.
https://asp.net
MIT License
501 stars 191 forks source link

Remove "Default" colors in WebTools #4348

Open ryanbrandenburg opened 3 years ago

ryanbrandenburg commented 3 years ago

The "default" colors in ClassificationDefinitions have been a source of confusion, and on consulting with Todd it seems they aren't desired by the WebTools team anyway. Let's get rid of them all to clarify things.

ghost commented 3 years ago

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

NTaylorMullen commented 3 years ago

The "default" colors in ClassificationDefinitions have been a source of confusion, and on consulting with Todd it seems they aren't desired by the WebTools team anyway. Let's get rid of them all to clarify things.

Could you expand a bit more on this. Not sure I follow

ryanbrandenburg commented 3 years ago

I'm referring to the defaults such as https://devdiv.visualstudio.com/DevDiv/_git/WebTools?path=%2Fsrc%2FLanguages%2Fhtml%2FEditor%2FClassification%2FClassificationDefinitions.cs&version=GBmain&line=48&lineEnd=50&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents.