dotnet / razor

Compiler and tooling experience for Razor ASP.NET Core apps in Visual Studio, Visual Studio for Mac, and VS Code.
https://asp.net
MIT License
500 stars 191 forks source link

[VSCode] Add ="" to built-in tag helper completion #4543

Open marcusturewicz opened 4 years ago

marcusturewicz commented 4 years ago

Describe the solution you'd like

For IntelliSense completion on built in tag helpers (asp-action, asp-page etc), it would be nice for the completion to include the equals and quotation characters, like the HTML attributes do. See GIF below.

Additional context

I'm using VS Code, not sure if this already works in full VS or not.

Screen Recording 2020-07-26 at 4 49 05 pm

marcusturewicz commented 4 years ago

Happy to have a crack at this, if pointed in the right direction :)

mkArtakMSFT commented 4 years ago

Thanks for your suggestion, @marcusturewicz. Given the fragility of this area we think this one is a better fit for the team to handle.

TanayParikh commented 4 years ago

Current Implementation: commit_char_minimum_fix

We had previously supported ="|" quotes when you press =, but that functionality was removed to avoid issues like:

The LSP spec doesn't currently allow different CompletionItem.InsertText snippets for different commit characters. However, for the commit characters : and =, we need snippet texts of :| and ="|" respectively.