dotnet / razor

Compiler and tooling experience for Razor ASP.NET Core apps in Visual Studio, Visual Studio for Mac, and VS Code.
https://asp.net
MIT License
495 stars 191 forks source link

Latest VSMain C# diagnostics linger #4837

Closed NTaylorMullen closed 2 years ago

NTaylorMullen commented 3 years ago

In latest VSMain with latest .NET SDK opening a Razor project results in 1 set of diagnostics being produced (the current state of the file). Afterwards no diagnostics are generated (or regenerated).

Debugging through it looks like we ask C# for diagnostics at which point they don't return any updated diagnostics. Recently design time bits moved towards using SourceGenerator enabled solutions so the initial thought was that SourceGenerators were the issue because on solution open we'd get: image

However, after working with the aspnetcore runtime team, them fixing the issue, the diagnostics still show issue.

Other Notes:

NTaylorMullen commented 3 years ago

Issue lies in Roslyn: https://github.com/dotnet/roslyn/issues/52980

NTaylorMullen commented 3 years ago

Fixed