Improve and Un-skip Rename Integration tests

dotnet / razor

Compiler and tooling experience for Razor ASP.NET Core apps in Visual Studio, Visual Studio for Mac, and VS Code.

https://asp.net

MIT License

489 stars 190 forks source link

Improve and Un-skip Rename Integration tests #8121

Open ryanbrandenburg opened 1 year ago

ryanbrandenburg commented 1 year ago

They currently fail with a couple of problems. Some of those issues are on the WebTools/Platform end (https://devdiv.visualstudio.com/DevDiv/_git/WebTools/pullrequest/444996, https://devdiv.visualstudio.com/DevDiv/_git/WebTools/pullrequest/444453 and https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1715306/) once those are resolved and merged we should re-visit.

DoctorKrolic commented 12 months ago

@davidwengier Are the underlying problems resolved here? I keep revisiting this issue from time to time since I still want to add integration tests for renaming component's type parameter as I mentioned in https://github.com/dotnet/razor/pull/8909 (serious dedication, isn't it). I remember you did Tuesday endpoint cleanup days, maybe it's a good idea to have "Tuesday cleanup and reenable integration tests day" this week then)

davidwengier commented 12 months ago

I don't honestly know. You are welcome to put up a PR with a new test, or with the existing tests unskipped, and see whether the CI is green. There have been lots of changes since they were disabled, but I can't say whether they will have worked around any issues, and I'm on my phone so can't check the internal MS links.