dotnet / reproducible-builds

Contains the DotNet.ReproducibleBuilds package
MIT License
168 stars 18 forks source link

Required workaround? #17

Closed olivier-spinelli closed 2 years ago

olivier-spinelli commented 2 years ago

I haven't seen this workaround in the props/targets: https://github.com/dotnet/sdk/issues/1458#issuecomment-695119194

Shoud we add it? Couldn't it be added in a upcoming 1.1.2 version?

(I'm must admit that I'm quite lost in the NuGet/MSBuild current complexity.)

baronfel commented 2 years ago

Hello, I'm not sure this is the correct repo for this suggestion. This repo is primarily for build determinism and standardized sourcelink configuration, but your link is about copying PDBs from dependencies into your built/packaged outputs. Can you describe what change you think would need to be made here?

olivier-spinelli commented 2 years ago

You are totally right. I was hoping that this package could be a kind of NuGet fixer that could deal with all the complexity of NuGet/MSBuild.

I'm currently fighting to settle a generic Directory.Build.props (ie. standardazing multiple repositories)... and suffering. I'm closing this issue (sorry).