search

dotnet / reproducible-builds

Contains the DotNet.ReproducibleBuilds package
MIT License
168 stars 18 forks source link

Populate RepositoryBranch package metadata if available #27

Closed kzu closed 1 year ago

kzu commented 1 year ago

Only do so if PublishRepositoryUrl=true, meaning you want this information to be public in the first place.

See RepositoryBranch in https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets.

baronfel commented 1 year ago

This seems very reasonable, but I have to admit that my first thought was 'why isn't this in dotnet/sourcebuild?'. I looked in that repo and they don't do anything for RepositoryBranch, so I was surprised.

kzu commented 1 year ago

Gently pinging @clairernovotny 😉

kzu commented 1 year ago

Anything stopping this PR from merging? Polysharp also waiting on this ... https://github.com/Sergio0694/PolySharp/pull/24#discussion_r1024511185

@clairernovotny ?

clairernovotny commented 1 year ago

@baronfel ?

baronfel commented 1 year ago

Thanks @kzu, and sorry for this one falling through the cracks.

kzu commented 1 year ago

How does this ship? Is it automatic? Did it ship already?

kzu commented 1 year ago

This still hasn't shipped: https://www.nuget.org/packages/DotNet.ReproducibleBuilds

baronfel commented 4 days ago

We've shipped this in 1.2.4 at long last!