Reconsideration of Source Embedding

dotnet / reproducible-builds

Contains the DotNet.ReproducibleBuilds package

MIT License

168 stars 18 forks source link

Reconsideration of Source Embedding #34

Open aetos382 opened 9 months ago

aetos382 commented 9 months ago

Using this package, the following options are set.

<DebugType>embedded</DebugType>.
<EmbedUntrackedSources>true</EmbedUntrackedSources>

With this setting, all source code generated by Source Generators will be embedded in the EXE/DLL via PDB. I think that these source embedding options need to be reconsidered.

MattKotsenas commented 7 hours ago

Can you tell me more about the impact / downside?

Are you in a scenario where your source generator is generating a large amount of code and bloating PDB? Is the source generator generating non-deterministic code?

Depending on the scenario, we may want to change our guidance / defaults, however without knowing more about the scenario I'm hesitant to suggest changes here.