search

dotnet / reproducible-builds

Contains the DotNet.ReproducibleBuilds package
MIT License
168 stars 18 forks source link

Feature/msbuild nuget #6

Closed ghost closed 3 years ago

ghost commented 3 years ago

Creates an Sdk nuget package that configures build for isolation from other installed software and sdks.

clairernovotny commented 3 years ago

Can you please update the azure pipeline yaml to build the package?

ghost commented 3 years ago

@clairernovotny I believe this is ready to go in once you're happy with it.

clairernovotny commented 3 years ago

Does this package need to be in the form of an MSBuild SDK or can it be a regular NuGet package with props/targets? Nothing is standing out at me that requires an SDK. I think SDK'are are harder for people to use than regular nuget packages.

ghost commented 3 years ago

@clairernovotny I'm currently using SDK so that we can conditionally add the PackageReference to reference assemblies as needed. I also suspect that we'll likely need to add more logic to mess with package references as we go, because of how tricky the frameworkreference mechanism is. I'd rathe bite the bullet now, rather than find out later that we need to convert to Sdk and break existing users.

Also, it's easier to move back to PackageReference from SDK than vice versa. If we can later show that Sdk is entirely unnecessary, we can make the change then.

clairernovotny commented 3 years ago

Gotcha, missed that part.