search

dotnet / roslyn-analyzers

MIT License
1.59k stars 466 forks source link

PublicAPI analyzer double-lists accessors of forwarded types #1193

Open jasonmalinowski opened 7 years ago

jasonmalinowski commented 7 years ago

If a type is forwarded, we're listing both the properties and accessors twice:

Microsoft.CodeAnalysis.Options.OptionKey.Language { get; } -> string (forwarded, contained in Microsoft.CodeAnalysis) 
Microsoft.CodeAnalysis.Options.OptionKey.Language.get -> string (forwarded, contained in Microsoft.CodeAnalysis)

We don't do this for non-forwarded types.

mavasani commented 5 years ago

Duplicate of https://github.com/dotnet/roslyn-analyzers/issues/2195

jasonmalinowski commented 5 years ago

@mavasani Not entirely sure you want to dupe this one -- the code is really funky here so I could imagine somebody fixing #2195 and missing this.

mavasani commented 5 years ago

Ah, I thought this was not really related to forwarded types, but partial types. I'll re-open and let @genlu triage appropriately.