Remove the workaround to get CFG for local functions/lambda

dotnet / roslyn-analyzers

MIT License

1.59k stars 466 forks source link

Remove the workaround to get CFG for local functions/lambda #1812

Open mavasani opened 6 years ago

mavasani commented 6 years ago

See https://github.com/dotnet/roslyn/issues/29836 for the limitations of GetAnonymousFunctionControlFlowGraph and GetLocalFunctionControlFlowGraph. This forced us to put a workaround in dataflow analysis code. This issue tracks removing the workaround on our side once the Roslyn feature request is implemented.

Evangelink commented 3 years ago

@mavasani I have just made a new try at removing the workaround and we still have a couple of tests failing with Specified argument was out of the range of valid values. (Parameter 'anonymousFunction') (e.g. test LambdaMultipleCallsOsDependentMember_MixedGuardedCalls).

I am wondering if there is still a bug on roslyn's side.