search

dotnet / roslyn-analyzers

MIT License
1.59k stars 465 forks source link

PerformanceSensitive: Wrong severity for diagnostics #2260

Open edespong opened 5 years ago

edespong commented 5 years ago

Follow-up from review at https://github.com/dotnet/roslyn-analyzers/pull/2214#issuecomment-478129830

Is the severity Info the correct one for all of the rules?

The severity should not change as part of this pull request. A follow-up issue should be filed to change the severity to warning if it is not already that.

There are several diagnostics reporting Info for the PerformanceSensitive analyzers: ArrayCreationRule (HAA0501) ObjectCreationRule (HAA0502) AnonymousObjectCreationRule (HAA0503) LetCauseRule (HAA0506) ReadonlyMethodGroupAllocationRule (HeapAnalyzerReadonlyMethodGroupAllocationRule)

Evangelink commented 4 years ago

Is it something community can help with or do you need to have some internal decision?