search

dotnet / roslyn-analyzers

MIT License
1.59k stars 465 forks source link

Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers missing from nuget #2718

Open chinwobble opened 5 years ago

chinwobble commented 5 years ago

Analyzer package

Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers

Package Version

Example: v2.9.4 (Latest)

I see in the repo that one of the packages that the build produces is Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers but I'm not able to see it in the readme.md at the root or the solution or on nuget. Can you advise what is the status of this package?

Expected behavior

Available for download on nuget

Actual behavior

Not available on nuget

mavasani commented 5 years ago

Tagging @genlu @sharwell - This is currently an internal-only package only meant for private consumption.

chinwobble commented 5 years ago

are there any plans to make this available on nuget? It looks pretty useful.

sharwell commented 5 years ago

@chinwobble Yes, we want to make it public but we haven't don't any validation to make sure it meets quality or performance expectations.

chinwobble commented 5 years ago

@sharwell any idea when this will be available?

genlu commented 4 years ago

@chinwobble We are trying to dogfood it internally (see https://github.com/dotnet/roslyn/pull/41444), but don't have a date for final release yet. Meanwhile you can pick it up and try it from our myget feed: https://dotnet.myget.org/feed/roslyn-analyzers/package/nuget/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers

KalleOlaviNiemitalo commented 3 years ago

https://github.com/dotnet/roslyn-analyzers/pull/2117 added License notice for Roslyn Clr Heap Allocation Analyzer to THIRD-PARTY-NOTICES.txt but not to assets/ThirdPartyNotices.rtf, which is included in the NuGet package. Based on the precedent in #2386, I guess the license notice should be added there too, before the package is published to nuget.org. Or replace assets/ThirdPartyNotices.rtf with THIRD-PARTY-NOTICES.txt in the NuGet packages.

Youssef1313 commented 1 year ago

@genlu @sharwell @mavasani What is remaining on this? Anything in particular can be done here by community contributors?

sharwell commented 1 year ago

I don't think anyone is currently working on it from either the conceptual or implementation side.