Feature request for CA1717: Make configurable the culture of the rule

[artberri]

Analyzer package

Microsoft.CodeQuality.Analyzers

Package Version

Unreleased code in master

Diagnostic ID

CA1717

Repro steps

Recently (https://github.com/dotnet/roslyn-analyzers/pull/2809), the CA1717 rule has been modified to avoid checking for plurals conditionally based on the region settings of the the user's computer, while talking about it, this feature request come to our minds.

It happens that this check is done using only the English language, so, if your code base is written in other language this check will not be useful for you.

Feature request

• Add a configurable option to set the language of the code base and make the CA1717 rule dependent on this option.

Notes

This analyzer depends on Humanizer for detecting single/plural words. Humanizer supports multiple language packages. Right now the CA1717 rule is using only the English version but is supposed that we could add more to check other languages also.

[Evangelink]

It doesn't seem that complex to implement but I am wondering whether this is a good direction. I am not an expert of the topic but I think that lately there seems to be more of a consensus toward avoiding translations of developer oriented "elements" (I think there were some discussion about translations of exception messages...).

Just my 2cts

[Evangelink]

Any opinion here @mavasani

[mavasani]

Lets wait for more feedback here.