search

dotnet / roslyn-analyzers

MIT License
1.58k stars 463 forks source link

Public API Code Fix should support updating shipped API signature #5782

Open tmat opened 2 years ago

tmat commented 2 years ago

When a shipped API signature is updated the Public API Analyzer should insert *REMOVED* marker to PublicAPI.Unshipped.txt file with the previous signature in addition to the new signature.

tmat commented 2 years ago

Actually, let's just remove this analyzer and code fixes and replace them with a source generator with output files checked in.

tmat commented 2 years ago

Issue tracking redesign: https://github.com/dotnet/roslyn-analyzers/issues/5787

jasonmalinowski commented 2 years ago

In the design meeting there was general agreement that we need to rethink this whole design, so @tmat filed #5787 to do so. In the meantime, this bug is tracking the original proposal, which is if you're updating a shipped API to also add the REMOVED tag to the unshipped file.

mattleibow commented 1 year ago

This will be nice to have so we can ensure the tooling doesn't go edit shipped files because when we remove overrides because we made code better, we have to go edit 10 files for all our TFMs and variations.