search

dotnet / roslyn-analyzers

MIT License
1.6k stars 468 forks source link

Microsoft.CodeAnalysis.ResxSourceGenerator does not support i18n #7041

Closed 2A5F closed 11 months ago

2A5F commented 1 year ago

Analyzer source

NuGet Package: Microsoft.CodeAnalysis.ResxSourceGenerator

Version: 3.11.0-beta1.23525.2 (Latest)

Describe the bug

image image

sharwell commented 11 months ago

The analyzers should support localization, and we use it for this in some other repositories. Can you post a sample project where you encountered this problem? I found that a reference to Microsoft.CodeAnalysis.Analyzers was causing a conflict in one case, but updating it to use the same version as Microsoft.CodeAnalysis.ResxSourceGenerator fixed it: https://github.com/DotNetAnalyzers/StyleCopAnalyzers/commit/271f1d485634951ea3adf60adebbc9f01fe55182

2A5F commented 11 months ago

@sharwell https://github.com/2A5F/TestLocalization_for_ResxSourceGenerator

sharwell commented 11 months ago

In the sample repository, Microsoft.CodeAnalysis.Analyzers uses version 3.3.4 while Microsoft.CodeAnalysis.ResxSourceGenerator uses 3.11.0-beta1.23525.2. This normally would not be a problem, but there is a bug in Microsoft.CodeAnalysis.Analyzers 3.3.4 that causes it to overwrite the build logic that makes ResxSourceGenerator properly handle culture-specific resources.

Updating Microsoft.CodeAnalysis.Analyzers to 3.11.0-beta1.23525.2 will resolve the problem.

xPaw commented 3 months ago

I think I am seeing a similar problem in https://github.com/JustArchiNET/ArchiSteamFarm project

I tried the following:

    <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0-beta1.24324.1" />
    <PackageVersion Include="Microsoft.CodeAnalysis.ResxSourceGenerator" Version="3.11.0-beta1.24324.1" />

and it still generates class no-NO and class zh-Hant-HK, producing spammy errors:

Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp.CSharpResxGenerator\Strings.Designer.cs(9,33,9,40): error CS0101: The namespace 'ArchiSteamFarm.Localization' already contains a definition for 'Strings'
Microsoft.CodeAnalysis.ResxSourceGenerator.CSharp.CSharpResxGenerator\Strings.no-NO.Designer.cs(11,66,11,83): error CS0116: A namespace cannot directly contain members such as fields, methods or statements

Weirldy it only fails to compile in Visual Studio (version 17.11.2). dotnet build works fine.

xPaw commented 2 months ago

@sharwell can this issue be reopened?