search

dotnet / roslyn-analyzers

MIT License
1.56k stars 462 forks source link

Stop publishing of additional packages #7282

Closed NikolaMilosavljevic closed 3 months ago

NikolaMilosavljevic commented 3 months ago

Fixes: https://github.com/dotnet/source-build/issues/4204

In the past we've required additional packages to be published to VMR location, during source-build. This was carried over with recent publishing work that modified VMR build to use regular arcade publishing infra - https://github.com/dotnet/source-build/issues/4204

With new changes in https://github.com/dotnet/installer/pull/19343 this is not needed anymore.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.47%. Comparing base (e4d7ea6) to head (c867683).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7282 +/- ## ========================================== - Coverage 96.48% 96.47% -0.01% ========================================== Files 1443 1443 Lines 345375 345369 -6 Branches 11362 11362 ========================================== - Hits 333222 333205 -17 - Misses 9273 9284 +11 Partials 2880 2880 ```
NikolaMilosavljevic commented 3 months ago

This should not be merged before https://github.com/dotnet/installer/pull/19343. Depending on code flow speed, it could break the VMR build.