search

dotnet / roslyn-analyzers

MIT License
1.58k stars 464 forks source link

Reduce calls to GetUsedNamedTypes to only those types for which the data is needed. #7311

Closed ToddGrun closed 4 months ago

ToddGrun commented 4 months ago

marking as draft until I can profile this properly

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.48%. Comparing base (bc8aca0) to head (e077737).

:exclamation: Current head e077737 differs from pull request most recent head 942e820. Consider uploading reports for the commit 942e820 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7311 +/- ## ======================================= Coverage 96.47% 96.48% ======================================= Files 1443 1443 Lines 345400 345392 -8 Branches 11364 11363 -1 ======================================= + Hits 333239 333240 +1 + Misses 9282 9272 -10 - Partials 2879 2880 +1 ```
ToddGrun commented 4 months ago

Closing this PR as there isn't evidence that the users that are experiencing this slowdown are using a package version that includes a different optimization