search

dotnet / roslyn-analyzers

MIT License
1.58k stars 464 forks source link

Don't raise CA1849 when async version has fewer parameters #7318

Open CollinAlpert opened 4 months ago

CollinAlpert commented 4 months ago

Affected analyzer: UseAsyncMethodInAsyncContext Affected diagnostic ID: CA1849

This PR prevents CA1849 being raised when the async alternative has fewer parameters than the sync method.

Fixes #7289

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.48%. Comparing base (bc8aca0) to head (ac3b9a9). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7318 +/- ## ======================================== Coverage 96.47% 96.48% ======================================== Files 1443 1443 Lines 345400 345483 +83 Branches 11364 11365 +1 ======================================== + Hits 333239 333350 +111 + Misses 9282 9256 -26 + Partials 2879 2877 -2 ```