Suggest getting the span of List<T> for iterations

[Meir017]

consider the following code:

public void Method(List<int> list)
{
    // should trigger the analyzer
    foreach (var item in list)
    {
        Console.WriteLine(item);
    }
    list.ForEach(Console.WriteLine);

    // the suggested fix
    foreach (var item in CollectionsMarshal.AsSpan(list))
    {
        Console.WriteLine(item);
    }
}

Iterating over List without getting the span first.

Describe suggestions on how to achieve the rule

• check for invocation of the ForEach method on when the target is List<T>
• check for foreach loops where the collection is List<T>

my current solution for List<T>.ForEach is using the https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers.md and banning the List<T>.ForEach and having a comment suggesting to use our extension method ForEachSpan which gets the span from the list and then iterates over the list

[sharwell]

💭 I'm not sure the gains for this are worth giving up the _version check.