search

dotnet / roslyn-sdk

Roslyn-SDK templates and Syntax Visualizer
MIT License
498 stars 254 forks source link

Avoid unnecessary M.VisualBasic and S.ValueTuple dependencies #1142

Closed ViktorHofer closed 5 months ago

ViktorHofer commented 5 months ago

Found in https://github.com/dotnet/runtime/pull/96795#discussion_r1464797169

These packages shouldn't be referenced on modern TFMs as the types are already provided inbox by the framework.

FWIW, I'm not sure why roslyn-sdk targets out-of-support TFMs like net452 or net46: https://learn.microsoft.com/de-de/lifecycle/products/microsoft-net-framework. That goes against what Tactics agreed on in November. See https://github.com/dotnet/designs-microsoft/pull/74 for more details.

sharwell commented 5 months ago

FWIW, I'm not sure why roslyn-sdk targets out-of-support TFMs like net452 or net46

It's a testing package that supports testing Roslyn 1.x analyzers in Visual Studio 2015.

jaredpar commented 5 months ago

It's a testing package that supports testing Roslyn 1.x analyzers in Visual Studio 2015.

Tactics though decided that we're dropping support for older TFMs in our core packages going forward.