search

dotnet / roslyn-tools

Tools used in Roslyn based repos
MIT License
103 stars 75 forks source link

Code Fixup #1412

Open nimanikoo opened 2 months ago

nimanikoo commented 2 months ago

Hello, I hope you are well Thank you for helping open source and building this project for the .NET community Out of curiosity, I was reviewing the codes of this repository and I found some points that might be good to correct. The next thing is that you can use the primary constructor according to the latest version of .NET In some cases, we could have written the code in a more concise and readable manner and used expressions I am endeavoring to that the latest features and updates in the .NET ecosystem are seamlessly integrated into the project without conflicts. It's my goal to contribute to the continuous improvement of this project. I hope these things are helpful and I will be happy to contribute to the progress of this project Please check and let me know the result

nimanikoo commented 2 months ago

Hello, I reviewed the code and noticed something: in the SignTool module and in the JsonTypes.cs file, there are numerous constructors that are unnecessary and unused. They can be safely removed to clean up the code Furthermore, there are inconsistencies in the namespaces, which can be corrected to make long-term development easier