search

dotnet / roslyn-tools

Tools used in Roslyn based repos
MIT License
103 stars 76 forks source link

WPF inputs are not added to UpToDateCheckInput #156

Open sharwell opened 6 years ago

sharwell commented 6 years ago

Steps to reproduce:

  1. Build a project containing a XAML page
  2. Make a change to a XAML page (in a *.xaml file)
  3. Build the project again

Expected results:

The project builds.

Actual results:

The project does not build, reporting that it is already up to date.

Resolution steps:

Add the following somewhere in the toolset targets:

<ItemGroup>
  <UpToDateCheckInput Include="@(Page);@(Resource)" />
</ItemGroup>
tannergooding commented 6 years ago

FYI. @tmat

tmat commented 6 years ago

@sharwell Is the intention to add this workaround to RepoToolset such that all projects in all repos get it?

sharwell commented 6 years ago

@tmat That is correct. RepoToolset already contains many other similar workarounds.

tmat commented 6 years ago

@sharwell In that case it should be in Workarounds.targets: https://github.com/dotnet/roslyn-tools/blob/master/sdks/RepoToolset/tools/Workarounds.targets