dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.85k stars 4.01k forks source link

CSharpCodeActions.Add Using (fuzzy match) and related fixes after Rename Tracking Is Flakey #17818

Open jmarolf opened 7 years ago

jmarolf commented 7 years ago

Encountered in this PR

Jenkins Failure

MESSAGE:
No Active Light Bulbs in View!
+++++++++++++++++++
STACK TRACE:
 at Tao.Utilities.Extensions.ThrowUnexpectedResultException[TAction](TAction action, String message)
 at Roslyn.Hosting.Test.VerifyCodeActionsAction.ExecuteOnUIThread() in D:\j\workspace\windows_eta_o---d880a2eb\Closed\Hosting\RoslynTaoActions\Actions\EditorTestApp\VerifyCodeActionsAction.cs:line 125 
 at Roslyn.Hosting.Test.EditorAction.<Execute>b__0_0() in D:\j\workspace\windows_eta_o---d880a2eb\Closed\Hosting\Test\Actions\EditorTestApp\EditorAction.cs:line 21
 at Roslyn.Hosting.Test.EditorTestAppAction.<>c__DisplayClass25_0.<ExecuteOnUIThread>b__0() in D:\j\workspace\windows_eta_o---d880a2eb\Closed\Hosting\Test\Actions\EditorTestApp\EditorTestAppAction.cs:line 165
 --- End of stack trace from previous location where exception was thrown ---
 at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
 at Roslyn.Hosting.Test.EditorTestAppAction.ExecuteOnUIThread(Action a) in D:\j\workspace\windows_eta_o---d880a2eb\Closed\Hosting\Test\Actions\EditorTestApp\EditorTestAppAction.cs:line 178
 at Roslyn.Hosting.Test.EditorAction.Execute(TaoEngine engine) in D:\j\workspace\windows_eta_o---d880a2eb\Closed\Hosting\Test\Actions\EditorTestApp\EditorAction.cs:line 13
 at Tao.Engine.DebuggableActionExecutor.Execute() at Tao.Engine.DefaultActionExecutor.Execute()
genlu commented 7 years ago

Saw this again in #18238

https://ci.dot.net/job/Private/job/dotnet_roslyn-internal/job/dev16/job/windows_eta_open_prtest/48/testReport/junit/(root)/CSharpCodeActions/Add_Using__fuzzy_match__and_related_fixes_after_Rename_Tracking/

Pilchie commented 7 years ago

@rchande - did these get ported? Should we just close this bug?

MattGertz commented 7 years ago

Mondo escrow triage: test-only, moving out.