search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
19.13k stars 4.04k forks source link

Add IOperation API for BoundDiscardExpression #22633

Closed mavasani closed 6 years ago

333fred commented 6 years ago

@dotnet/analyzer-ioperation @AlekseyTs do we feel that we need this API in 15.7, or should I put it in the features/dataflow branch and we'll ship it with 15.8?

333fred commented 6 years ago

I'd vote for the latter.

AlekseyTs commented 6 years ago

I don't think this has to be bundled with dataflow, regardless of what we decide for the target milestone.

333fred commented 6 years ago

Fair enough. I just thought it would be a convenient branch.

AlekseyTs commented 6 years ago

I just thought it would be a convenient branch.

I think it is a bad idea to link unrelated bugs and features. If the feature doesn't ship when we expect, the bug remains.

AlekseyTs commented 6 years ago

I think it would be good to fix in 15.7, however this issue could be lower in priority by comparison to other IOperation issues.

333fred commented 6 years ago

Fixed in #25820.