search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.9k stars 4.01k forks source link

Copyright headers should indicate .NET Foundation, not Microsoft, is copyright holder #25423

Open jongalloway opened 6 years ago

jongalloway commented 6 years ago

Copyright headers should list .NET Foundation, similar to other .NET Foundation project source headers: https://github.com/dotnet/corefx/blob/master/src/System.Collections/src/System/Converter.cs

sharwell commented 6 years ago

Loosely related to #20745

jasonmalinowski commented 6 years ago

@jongalloway Is this something we should just have a developer change, or do we need somebody else to look over it, provide the exact copyright header, etc.?

jongalloway commented 6 years ago

You could probably have a dev do a find / replace, using the header in the CoreCLR or CoreFX repos. It probably wouldn't hurt to run by CELA if you've got questions, but for projects that join the foundation it's just a find / replace pull request.

sharwell commented 6 years ago

@jongalloway Can you reduce the header to a maximum of two lines? There are three approaches for this:

  1. Wrap as a paragraph
// Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this
// file to you under the MIT license. See the LICENSE file in the project root for more information.
  1. Place two sentences on the first line
// Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
  1. Place two sentences on the second line
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.
CyrusNajmabadi commented 6 years ago

Could we keep it as a single line? That would help keep the impact of this on all files as minimal as what we have today already.

CyrusNajmabadi commented 1 year ago

@jasonmalinowski anything we need to do here?