Open ddizh opened 5 years ago
dotnet build --no-restore
Did you run build.sh --restore
before this? It wasn't listed in the repro steps.
Note: in general you can't depend on dotnet build
working for projects in Roslyn.sln. There are some where it will work but it's not guaranteed as many projects utilize build tasks that depend on the desktop framework. Everything inside Compilers.sln can be built with dotnet
though.
Is it possible to de-couple these tests from WPF?
Possibly yes. It's a bit of work though and I'm unsure if its' on the IDE teams' radar at the moment.
Did you run build.sh --restore before this?
yes I did but does it really matter? AFAIK build.sh
only does things with Compilers.sln
which doesn't have a reference for Microsoft.CodeAnalysis.CSharp.EditorFeatures.UnitTests.csproj
So I guess the only way right now to test the changes in MoveType
refactoring is to build it locally, then build omnisharp with reference to my local Microsoft.CodeAnalysis.CSharp.Features.dll
. This makes the development on non-windows environments quite tricky.
yes I did but does it really matter?
Restore of the projects must happen in order for build to succeed. Lacking restore you will get all manner of build errors. True build.sh --restore
will only restore Compilers.sln. But there was no indication you were running restore during your repro hence it's a plausible source of error here.
This makes the development on non-windows environments quite tricky.
For this particular layer of the stack yes. I'll leave this to the IDE team to comment on their plans for enabling Mac base development of this layer. It should just come naturally as we move to .NET Core 3.0 but that's a ways down the road.
This is the first I've heard of somebody actually trying this, so this hasn't been something on our radar yet. That said, splitting those out would be a good thing to do.
The history here is years ago Features/EditorFeatures didn't exist as a distinct set of projects -- it was just EditorFeatures, and so the test projects matched it. When we needed to split the main projects, we never split the tests.
@jaredpar Will .NET Core 3.0 allow building of WPF apps on Mac, even if it can't run them?
@nguerrera can better answer that question but my understanding is yes it should.
We hope that it will work, but I can't promise that just yet.
Version Used: latest master
Steps to Reproduce:
Expected Behavior: Build succeeded
Actual Behavior:
Build failed with following errors:
I was trying to investigate and fix https://github.com/dotnet/roslyn/issues/30751 and decided to add more tests for MoveType refactoring. Is it possible to de-couple these tests from WPF?