dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.91k stars 4.01k forks source link

VB line commit should add missing argument parentheses #36545

Open sharwell opened 5 years ago

sharwell commented 5 years ago

Version Used: 16.2 Preview 2

:link: https://developercommunity.visualstudio.com/content/problem/567910/vs2019-intellisense-worst-than-vs2010.html

Steps to Reproduce:

  1. Type the following VB code:

    Console.WriteLine "Text"
  2. Press Enter

Expected Behavior:

Parentheses are automatically added:

Console.WriteLine("Text")

Actual Behavior:

The text is not changed, and error BC30800 is reported saying:

Method arguments must be enclosed in parentheses.

dddns commented 5 years ago

Thank you for this and the previous bug. Will monitor to track changes.

dddns commented 5 years ago

@sharwell for this fix, the expected behavior like vs2010, is to add the parentesis like vs2010 when enter is pressed or CTRL+s (save)

dddns commented 5 years ago

@sharwell I just updated to 16.2.0 and this still happens/not fixed.

dddns commented 4 years ago

Hi, Nock Nock, no fix for this yet?

CyrusNajmabadi commented 4 years ago

@dddns There is no one assigned to fix this. It's in the "help wanted" category. Meaning: if you'd like to see this fixed, your contributions to help this project would always be appreciated. Thanks! :)

dddns commented 4 years ago

@CyrusNajmabadi , more? It was me who reported this, they have a video with that bug explanation.

CyrusNajmabadi commented 4 years ago

more?

Sure :) As i mentioned, there is no one assigned to it and there are no votes for it. So it's unlikely to be fixed unless someone particularly feels like going and fixing it themselves. The best course of action if you'd like to see this change in a future version is just to submit a PR for it yourself :)

dddns commented 4 years ago

@sharwell already detected the bug/regression, i wont do nothing else.