search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
19.06k stars 4.04k forks source link

build failure #39096

Open tamlin-mike opened 5 years ago

tamlin-mike commented 5 years ago

HEAD

Build ends prematurely with many errors of the following kind

W:\Roslyn\roslyn\src\Scripting\CSharpTest\InteractiveSessionReferencesTests.cs(12,47): error CS0122: 'TestCompilationFactory' is inaccessible due to its protection level [W:\Roslyn\roslyn\src\Scripting\CSharpTest\Micr
osoft.CodeAnalysis.CSharp.Scripting.UnitTests.csproj]

Ideas? Are you perhaps using a different way to build it than Build.cmd?

huoyaoyuan commented 5 years ago

I can build with Build.cmd several minutes ago, but build inside VS before that reports errors.

tamlin-mike commented 5 years ago

What I did was basically just git clone, Update.cmd, Build.cmd.

VS16.3, which could be important.

jmarolf commented 5 years ago

restore.cmd && build.cmd should work. if you do git clean -xdf followed by restore.cmd && build.cmd /binaryLog and still see this failure could you share the *.binlog file?

tamlin-mike commented 5 years ago

If I switch back to master I might give it a whirl.

I just found it strange that it could work at all considering the error message "is inaccessible due to its protection level". Perhaps the testing build is somehow granting the tests access to otherwise inaccessible members/types, and I'm just unaware of the functionality? Combined with some other build issues I experinced at the time, that could explain it enough to close this issue.

jmarolf commented 5 years ago

@tamlin-mike there is some silliness going on with test certificates and what-not thought @tmat is the authority on whether this is expected or not (I would assume no)

jinujoseph commented 5 years ago

cc @dibarbet