search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.92k stars 4.02k forks source link

Suppressed errors/warnings are still visible in 16.4 preview 2 #39620

Open lorcanmooney opened 4 years ago

lorcanmooney commented 4 years ago

Version Used: Microsoft Visual Studio Community 2019 Preview Version 16.4.0 Preview 2.0 VisualStudio.16.Preview/16.4.0-pre.2.0+29411.138

Steps to Reproduce: suppressed_warning

Expected Behavior: Suppressed diagnostics are hidden from all views.

Actual Behavior: The diagnostics are still visible in the solution explorer (when using the productivity power tools).

I believe this regressed in 16.4 preview 1.

CyrusNajmabadi commented 4 years ago

Shouldn't this be filed against the PPTs? I don't believe roslyn controls this at all.

lorcanmooney commented 4 years ago

The latest release of Visual Studio - a point-release - has broken an extension which worked without issue for years. Why do you feel this is a problem with the extension?

CyrusNajmabadi commented 4 years ago

has broken an extension which worked without issue for years. Why do you feel this is a problem with the extension?

because absent anything else, only they know how they work and why they would have different behavior here. perhaps they operated on undocumented apis. perhaps a change was made to an api that was intentional. without thta tool indicating what the issue is, there's no way to tell.

jmarolf commented 4 years ago

The source for this is internal unfortunately but they are just listening for errors in the error list:

GlobalServices.ErrorList.TableControl.EntriesChanged += OnEntriesChanged;

however that are filtering to include items of type suppressionstate. I can check if the code here has changed (@sharwell might know), but it looks like this was always incorrect and only now are we reporting error categories so its surfacing now.

Internal MS folks can see the code here

sharwell commented 4 years ago

I'm not sure how Roslyn would be impacting this. The Solution Error Visualizer extension (part of PPT) operates against Visual Studio APIs and not against Roslyn directly, so this does appear to be a bug specifically in that extension.