search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.71k stars 3.98k forks source link

Move implementations of CompletionServiceWithProviders to MEF provider only #42367

Open genlu opened 4 years ago

genlu commented 4 years ago

We are considering deprecate and unhook builtin provider API in next major release.

genlu commented 4 years ago

FYI @brettfo @uniqueiniquity Here's an example: https://github.com/dotnet/roslyn/blob/master/src/Features/CSharp/Portable/Completion/CompletionProviders/KeywordCompletionProvider.cs#L20

uniqueiniquity commented 4 years ago

By the next major release, it's probable that we will be using LSP for completion instead of Roslyn, so this may be a non-issue by that point.