SymbolKeyTestBase.ResolveAndVerifySymbol ignores 'newCompilation' input parameter

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.

https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/

MIT License

19.13k stars 4.04k forks source link

SymbolKeyTestBase.ResolveAndVerifySymbol ignores 'newCompilation' input parameter #45894

Open mavasani opened 4 years ago

mavasani commented 4 years ago

See https://github.com/dotnet/roslyn/pull/45847/commits/6e0b6778e3fa44441c5cd1d6297bb3708a4be3be#diff-b21c98ba01bccb58ada91d6c25ac9422R32

Test helper has an unused newCompilation parameter. Should ResolveAndVerifySymbol calls below use newCompilation? We should either remove or respect this parameter.

mavasani commented 4 years ago

@CyrusNajmabadi

CyrusNajmabadi commented 4 years ago

yes. taht seems like a bug. ResolveAndVerifySymbolList should not take originalCompilation. It should only take newCompilation and pass that on isntead.