dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
19.12k stars 4.04k forks source link

Running Roslyn.Compilers.Extension does not change compiler used #46125

Open YairHalberstadt opened 4 years ago

YairHalberstadt commented 4 years ago

Version Used: roslyn master as of 16th july

Steps to Reproduce:

  1. Make some change in roslyn that should effect the compiler output, e.g. add/remove a diagnostic.
  2. Run Roslyn.Compilers.Extension. From https://github.com/dotnet/roslyn/blob/master/docs/contributing/Building,%20Debugging,%20and%20Testing%20on%20Windows.md#trying-your-changes-in-visual-studio:

    Roslyn.Compilers.Extension: this project can be found inside the Compilers\Packages folder from the Solution Explorer, and builds Roslyn.Compilers.Extension.vsix. This deploys a copy of the command line compilers that are used to do actual builds in the IDE. It only affects builds triggered from the Visual Studio experimental instance it's installed into, so it won't affect your regular builds. Note that if you install just this, the IDE won't know about any language features included in your build. If you're regularly working on new language features, you may wish to consider building both the CompilerExtension and VisualStudioSetup projects to ensure the real build and live analysis are synchronized.

  3. The change you made to roslyn will not be visible when you build in VS.
jinujoseph commented 4 years ago

cc @jcouv