EmitSequenceOfBinaryExpressions_06 is flaky

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.

https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/

MIT License

19.13k stars 4.04k forks source link

EmitSequenceOfBinaryExpressions_06 is flaky #46361

Open gafter opened 4 years ago

gafter commented 4 years ago

The test EmitSequenceOfBinaryExpressions_06 tests the limits of the compiler, but since it is not executed in a fresh thread we cannot predict how much stack space it has available. Therefore it might not reach the stack depth expected.

AlekseyTs commented 4 years ago

It looks like https://github.com/dotnet/roslyn/pull/46367 affected the test, there could be a real issue, i.e. we actually started consuming more stack.

gafter commented 4 years ago

I've seen that test fail both inside and outside of the changes in that PR. The test does not run on a fresh thread and therefore does not have a reliably reproducible amount of thread available.