Edit and continue symbol matchers assume that custom modifiers aren't present

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.

https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/

MIT License

18.73k stars 3.99k forks source link

Edit and continue symbol matchers assume that custom modifiers aren't present #4722

Open AlekseyTs opened 8 years ago

AlekseyTs commented 8 years ago

See relevant asserts and TODOs in src\Compilers\CSharp\Portable\Emitter\EditAndContinue\CSharpSymbolMatcher.cs and src\Compilers\VisualBasic\Portable\Emit\EditAndContinue\VisualBasicSymbolMatcher.vb.

Are these assumptions justified? If they are, we should remove the TODOs and probably capture justification in a comment. Otherwise, custom modifiers should be handled and the asserts should be removed.

@tmat FYI

tmat commented 8 years ago

@ManishJayaswal Moved to 1.3