search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
19.07k stars 4.04k forks source link

Remove RazorLanguageClient and ClientName from Roslyn LSP model #48209

Open CyrusNajmabadi opened 4 years ago

CyrusNajmabadi commented 4 years ago

This type existed so we could compute push diagnostics and get them sent across for C# or C#-razor. Now that we've switched to pull diags, this type (and all the logic related to it) can likely go away.

THis will require a change on Razor first (to no longer use this client-name), and then removal on our side of this server and the client name.

davidwengier commented 4 years ago

This should resolve #42630 too

davidwengier commented 4 years ago

We need to wait on AB#1224360 before pull diagnostics will be in Roslyn, and thus before this fix can be merged too.

davidwengier commented 4 years ago

@TanayParikh @CyrusNajmabadi is pull diagnostics still behind feature flags, or is this good to go now?

TanayParikh commented 4 years ago

@TanayParikh @CyrusNajmabadi is pull diagnostics still behind feature flags, or is this good to go now?

Still behind feature flags.

jinujoseph commented 3 years ago

Waiting for Pull diagnostics to be on by default