search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
19.04k stars 4.03k forks source link

Integration Tests should fail when info-bar is displayed #51091

Open tmat opened 3 years ago

tmat commented 3 years ago

It'd be useful to detect presence of any info-bars and fail integration tests. They should only be used for critical errors that should no occur during scenario testing.

sharwell commented 3 years ago

This check should probably belong before this line: https://github.com/dotnet/roslyn/blob/7b1087a25c9b8566cddb7800ed3b12fe94817fc3/src/VisualStudio/IntegrationTest/IntegrationTests/AbstractIntegrationTest.cs#L78

It should have a try/finally to ensure we still clean up on failure.

CyrusNajmabadi commented 1 week ago

@sharwell are we doing this now? Assigning to you.