Open CyrusNajmabadi opened 3 years ago
Very weird. The crash is on this line (According to the debugger in release mode):
diagBagForThisImport.Clear()
--> Dim data = New ModuleImportData(globalImport, membersMap, aliasesMap, membersBuilder, membersInfoBuilder, aliasesBuilder, aliasesInfoBuilder, xmlNamespaces, diagBagForThisImport.DependenciesBag)
Dim binder As Binder = BinderBuilder.CreateBinderForProjectImports(Me, VisualBasicSyntaxTree.Dummy)
However, tehre aren't any derefs on that line that are null. diagBagForThisImport
shows in the debugger as non-null.
Ah, it's a debugger issue, the line in questino is:
binder.BindImportClause(globalImport.Clause, data, diagBagForThisImport.DiagnosticBag)
globalImport
is null here. So taht seems like an issue that likely happened earlier, but wasn't caught until now.
Looks like we're failling to parse these global imports: Microsoft.VisualBasic,System,System.Collections,System.Collections.Generic,System.Diagnostics,System.Linq,IdentifierComparison = Microsoft.CodeAnalysis.CaseInsensitiveComparison,Roslyn.Utilities,Microsoft.VisualBasic,System,System.Collections,System.Collections.Generic,System.Diagnostics,System.Linq,System.Xml.Linq,System.Threading.Tasks
investigating further.
Compiler does produce this diagnostic, which it puts into its diag bag,
error BC30205: Error in project-level import 'Microsoft.VisualBasic,System,System.Collections,System.Collections.Generic,System.Diagnostics,System.Linq,IdentifierComparison = Microsoft.CodeAnalysis.CaseInsensitiveComparison,Roslyn.Utilities,Microsoft.VisualBasic,System,System.Collections,System.Collections.Generic,System.Diagnostics,System.Linq,System.Xml.Linq,System.Threading.Tasks' at 'System' : End of statement expected
However, it then crashes moments later so it can't be seen. Looks like VisualBasicOptions needs to be hardened to this so we can avoid the crash later on.
Running the lsifgenerator on Roslyn.sln itself produces this crash:
To run the lsifgenerator you can run:
Workign to see if i can get a dump now.