CSharpSyntaxGenerator doesn't appear to simplify when generating an attribute on a local function

[agocke]

I wrote the following code to add attributes to particular declarations

var editor = new SyntaxEditor (root, document.Project.Solution.Workspace);
var generator = editor.Generator;

var semanticModel = await document.GetSemanticModelAsync (cancellationToken).ConfigureAwait (false);
if (semanticModel is null) {
    return document;
}
var methodSymbol = (IMethodSymbol) semanticModel.GetDeclaredSymbol (methodDecl);
var name = semanticModel.GetSymbolInfo (targetNode).Symbol?.Name;
SyntaxNode[] attrArgs;
if (string.IsNullOrEmpty (name) || HasPublicAccessibility (methodSymbol)) {
    attrArgs = Array.Empty<SyntaxNode> ();
} else {
    attrArgs = new[] { generator.LiteralExpression ($"calls {name}") };
}

var newAttribute = generator
    .Attribute (generator.TypeExpression (requiresUnreferencedCodeSymbol), attrArgs)
    .WithAdditionalAnnotations (
        Simplifier.Annotation,
        Simplifier.AddImportsAnnotation);

editor.AddAttribute (methodDecl, newAttribute);

return document.WithSyntaxRoot (editor.GetChangedRoot ());

This generates an attribute correctly for local functions, but the type name is always fully qualified. Declaration forms that are not local functions appear to work correctly.

[Youssef1313]

Similar (identical?) thing is done here:

https://github.com/dotnet/roslyn/blob/6da1274c9d24c2f90a48290394a951b23617f2a3/src/Features/Core/Portable/AddDebuggerDisplay/AbstractAddDebuggerDisplayCodeRefactoringProvider.cs#L150-L156

But it works as shown by the following test:

https://github.com/dotnet/roslyn/blob/6da1274c9d24c2f90a48290394a951b23617f2a3/src/EditorFeatures/CSharpTest/AddDebuggerDisplay/AddDebuggerDisplayTests.cs#L18-L34

I guess a repro may help.

[agocke]

You should be able to repro by passing a local function syntax as the target. I expect the DebuggerDisplay code would have the same problem, but you can't add debugger display on local functions regardless.

[Youssef1313]

Oh so this is very specific to local functions? Will try to give it a look.

[Youssef1313]

ImportAdder does add the using statement, but it's removed after ReduceAsync is called. Trying to dig more into this.

[Youssef1313]

When using a normal method:

---

When using a local function:

The boundParent in the second case should have been BoundAttribute like in the first case.

(Issue should be assigned Area-Compilers instead)